fix(templates/kubit): logic inversion on kubitSingleNamespace #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this PR setting `Values.kubitSingleNamespace` to `false` would
cause it to watch only a single namespace, which seems to be the `kubit`
namespace itself. The reason it ends up watching the `kubit` namespace
can be seen in the deployment's namespace setting:
```
namespace: {{if .Values.kubitSingleNamespace}}{{.Values.namespaceOverride | default .Release.Namespace}}{{else}}kubit{{end}}
```
jenniferplusplus
approved these changes
May 23, 2024
waynr
deleted the
influxdb3-clustered/fix-kubit-singlenamespace-logic-inversion
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR setting
Values.kubitSingleNamespacetofalsewouldcause it to watch only a single namespace, which seems to be the
kubitnamespace itself. The reason it ends up watching the
kubitnamespacecan be seen in the deployment's namespace setting:
(ie we hit the
elsebranch in this logic whenkubitSingleNamespaceis false)